salior/salior/skills/review.md

1.1 KiB

Review Skill

Use this when reviewing code, decisions, or architecture.

Steps

  1. Understand — Read the full context before judging
  2. Pressure test — What's the weakest part? The hidden assumption?
  3. Check against requirements — Does this actually solve the stated problem?
  4. Consider alternatives — Is there a simpler approach?
  5. Flag clearly — Distinguish bugs from style preferences

Verification Gate

  • Bug: Must be fixed before merge
  • Style: Suggest only if it impacts readability
  • Architecture: Propose an alternative, don't just criticize

Review Categories

Category Priority Action
Correctness bug CRITICAL Block merge
Security issue CRITICAL Block merge
Performance regression HIGH Discuss
Missing test MEDIUM Suggest
Style/naming LOW Optional
Architecture MEDIUM Discuss

Output Format

# Review: [item]

## Summary
[One paragraph overview]

## Issues (blocking)
- [list]

## Issues (non-blocking)
- [list]

## Recommendations
- [list]

## Verdict: APPROVE / REQUEST_CHANGES / BLOCK